fix(server): return 400 on malformed assetIds query parameter (#502)#537
Closed
SAY-5 wants to merge 1 commit into
Closed
fix(server): return 400 on malformed assetIds query parameter (#502)#537SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Contributor
|
Already fixed in #511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #502.
The
_get_shellshandler base64url-decoded eachassetIdsquery parameter, JSON-parsed it, then directly indexedasset_dict["name"]andasset_dict["value"]. A client-supplied payload missing either key (or a non-object JSON value, or invalid JSON) propagated as an unhandled exception, producing a 500 Internal Server Error.Wrap the JSON parse and the field lookups so client-side validation failures return
BadRequest(400) with a clear message, matching the rest of the handler's error model.